RFR: 8229517: Support for optional asynchronous/buffered logging [v17]

[Paul Hohensee]

On Thu, 20 May 2021 09:08:04 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> This patch provides a buffer to store asynchrounous messages and flush them to
>> underlying files periodically.
>
> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update according to reviewer's feedback.

A few comment typos, but otherwise looks fine.

src/hotspot/share/logging/logAsyncWriter.cpp line 121:

> 119:   // Use kind of copy-and-swap idiom here.
> 120:   // Empty 'logs' swaps the content with _buffer.
> 121:   // Along with logs destruction, all procceeded messages are deleted.

procceeded -> preceding

src/hotspot/share/logging/logAsyncWriter.cpp line 170:

> 168:       Atomic::release_store_fence(&AsyncLogWriter::_instance, self);
> 169:       // All readers of _instance after the fence see non-NULL.
> 170:       // We make use LogOutputList's RCU counters to ensure all synchronous logsites have completed.

Delete 'make'.

src/hotspot/share/logging/logAsyncWriter.cpp line 171:

> 169:       // All readers of _instance after the fence see non-NULL.
> 170:       // We make use LogOutputList's RCU counters to ensure all synchronous logsites have completed.
> 171:       // After that, we start AsyncLog Thread and it exclusively takee over all logging I/O.

takee -> takes

src/hotspot/share/logging/logAsyncWriter.hpp line 26:

> 24: #ifndef SHARE_LOG_ASYNC_WTRITER_HPP
> 25: #define SHARE_LOG_ASYNC_WTRITER_HPP
> 26: #include "logging/log.hpp"

Use SHARE_LOGGING_LOGASYNCHWRITER_HPP to conform with existing naming standard.

src/hotspot/share/logging/logAsyncWriter.hpp line 128:

> 126:   AsyncLogBuffer _buffer;
> 127: 
> 128:   // The memory use of each AsyncLogMessage(payload) consist of itself and a variable-length c-str message.

consist -> consists

-------------

Marked as reviewed by phh (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3135