RFR: 8229517: Support for optional asynchronous/buffered logging [v17]
Xin Liu
xliu at openjdk.java.net
Fri May 21 07:03:39 UTC 2021
On Fri, 21 May 2021 06:10:43 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update according to reviewer's feedback.
>
> src/hotspot/share/logging/logAsyncWriter.cpp line 179:
>
>> 177: log_debug(logging, thread)("AsyncLogging starts working.");
>> 178: } else {
>> 179: log_warning(logging, thread)("AsyncLogging failed to launch thread. fall back to synchronous logging.");
>
> "Async logging failed to create thread. Falling back to synchronous logging."
>
> Shouldn't this be done where the os::create_thread failed though?
make sense. I think I can move "Async logging failed to create thread. Falling back to synchronous logging."
-------------
PR: https://git.openjdk.java.net/jdk/pull/3135
More information about the hotspot-dev
mailing list