RFR: 8229517: Support for optional asynchronous/buffered logging [v17]

Xin Liu xliu at openjdk.java.net
Fri May 21 17:33:10 UTC 2021


On Fri, 21 May 2021 09:13:53 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update according to reviewer's feedback.
>
> src/hotspot/share/logging/logAsyncWriter.cpp line 155:
> 
>> 153:   }
>> 154: 
>> 155:   assert(_state == ThreadState::Terminated, "sanity check");
> 
> I can't seem to find where `_state` is set to `ThreadState::Terminated` in this PR.

Yes, it's another historical problem. I used to have AsyncLogWriter::terminate(), but Thomas said I can avoid the complexity by leaving it alone. 

remove if not in use?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3135


More information about the hotspot-dev mailing list