RFR: 8229517: Support for optional asynchronous/buffered logging [v17]
Xin Liu
xliu at openjdk.java.net
Fri May 21 20:28:13 UTC 2021
On Fri, 21 May 2021 18:28:47 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Yes, it's another historical problem. I used to have AsyncLogWriter::terminate(), but Thomas said I can avoid the complexity by leaving it alone.
>>
>> remove if not in use?
>
>> remove if not in use?
>
> Yes, please.
>
> Shouldn't this assertion be triggered as it is now? Why no failing tests?
it's because while (_state == ThreadState::Running) is a dead loop.
Nobody attempts to terminate AsyncLog Thread.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3135
More information about the hotspot-dev
mailing list