RFR: 8229517: Support for optional asynchronous/buffered logging [v17]

David Holmes david.holmes at oracle.com
Sat May 22 02:41:31 UTC 2021


On 22/05/2021 11:14 am, Xin Liu wrote:
> On Fri, 21 May 2021 06:04:31 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>>>
>>>    Update according to reviewer's feedback.
>>
>> src/hotspot/share/logging/logAsyncWriter.cpp line 118:
>>
>>> 116: };
>>> 117:
>>> 118: void AsyncLogWriter::perform_IO() {
>>
>> Seems to be all O and no I :)
> 
> Let's call it "IO" for tradition. It would become more confusing if I changed it to `perform_O`

You could just call it write() or writeToLogs() or outputToLogs() or ...

David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/3135
> 


More information about the hotspot-dev mailing list