RFR: 8229517: Support for optional asynchronous/buffered logging [v17]

David Holmes david.holmes at oracle.com
Sat May 22 02:42:23 UTC 2021


On 22/05/2021 11:34 am, Xin Liu wrote:
> On Thu, 20 May 2021 20:15:04 GMT, Paul Hohensee <phh at openjdk.org> wrote:
> 
>>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>>>
>>>    Update according to reviewer's feedback.
>>
>> src/hotspot/share/logging/logAsyncWriter.hpp line 26:
>>
>>> 24: #ifndef SHARE_LOG_ASYNC_WTRITER_HPP
>>> 25: #define SHARE_LOG_ASYNC_WTRITER_HPP
>>> 26: #include "logging/log.hpp"
>>
>> Use SHARE_LOGGING_LOGASYNCHWRITER_HPP to conform with existing naming standard.
> 
> Oh, there's a hidden naming convention here.
> thanks for the head-up!

It's not hidden, it is the path + filename.

David

> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/3135
> 


More information about the hotspot-dev mailing list