RFR: 8229517: Support for optional asynchronous/buffered logging [v17]

Xin Liu xliu at openjdk.java.net
Sat May 22 09:10:27 UTC 2021


On Fri, 21 May 2021 05:55:50 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update according to reviewer's feedback.
>
> src/hotspot/share/logging/logAsyncWriter.hpp line 115:
> 
>> 113: class AsyncLogWriter: public NonJavaThread {
>> 114:   static AsyncLogWriter* _instance;
>> 115:   static Semaphore _sem;
> 
> What is this semaphore for? A comment and/or a more meaningful name would be good.

I added some comments here and _sem.wait().

-------------

PR: https://git.openjdk.java.net/jdk/pull/3135


More information about the hotspot-dev mailing list