RFR: 8229517: Support for optional asynchronous/buffered logging [v19]
Xin Liu
xliu at openjdk.java.net
Mon May 24 03:09:18 UTC 2021
On Sat, 22 May 2021 21:27:59 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update according to reviewers' feedback (Part-2).
>
> src/hotspot/share/logging/logAsyncWriter.cpp line 134:
>
>> 132: _buffer.pop_all(&logs);
>> 133: // append meta-messages of dropped counters
>> 134: _stats.iterate(&dropped_counters_iter);
>
> Any particular reason why the iterator is *not* declared right above its usage? IOW, why not
>
>
> _buffer.pop_all(&logs);
> AsyncLogMapIterator dropped_counters_iter(logs);
> _stats.iterate(&dropped_counters_iter);
yes, it works. I will update it.
I unconsciously wrote code in C style. ie. declarations come first, code snippet follows.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3135
More information about the hotspot-dev
mailing list