RFR: 8229517: Support for optional asynchronous/buffered logging [v20]
Xin Liu
xliu at openjdk.java.net
Mon May 24 22:55:34 UTC 2021
On Mon, 24 May 2021 08:51:27 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>>
>> flush() waits until all pending logging IO operations are done.
>>
>> This patch support all gtests in async mode.
>> make test TEST="gtest:all" TEST_OPTS='VM_OPTIONS=-Xlog:async'
>
> src/hotspot/share/logging/logAsyncWriter.hpp line 147:
>
>> 145: Initialized,
>> 146: Running,
>> 147: Terminated,
>
> These two states can be removed now, right? If so, maybe having a binary state (`volatile bool _initialized`) is enough and easier to follow.
make sense. I will update it along with the trywait() patch.
-------------
PR: https://git.openjdk.java.net/jdk/pull/3135
More information about the hotspot-dev
mailing list