RFR: 8229517: Support for optional asynchronous/buffered logging [v20]

[David Holmes]

On Mon, 24 May 2021 04:12:54 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> This patch provides a buffer to store asynchrounous messages and flush them to
>> underlying files periodically.
>
> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   flush() waits until all pending logging IO operations are done.
>   
>   This patch support all gtests in async mode.
>   make test TEST="gtest:all" TEST_OPTS='VM_OPTIONS=-Xlog:async'

Nothing further from me. Other than two typos my comments hadn't yet been sent for.

Thanks,
David

src/hotspot/share/logging/logAsyncWriter.cpp line 73:

> 71: 
> 72: // LogMessageBuffer consists of a multiple-part/multiple-line messsage.
> 73: // The lock here gurantees its integrity.

Typo: gurantees

src/hotspot/share/logging/logAsyncWriter.hpp line 117:

> 115: //
> 116: // Summary:
> 117: // Async Logging is working on the basis of singleton AsyncLogWriter, which manages an immediate buffer and a flushing thread.

typo: immediate -> intermediate

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/3135