RFR: 8266749: AArch64: Backtracing broken on PAC enabled systems [v3]

Alan Hayward github.com+4146708+a74nh at openjdk.java.net
Thu May 27 10:30:44 UTC 2021


On Wed, 26 May 2021 08:23:13 GMT, Andrew Haley <aph at openjdk.org> wrote:

> Would it not make more sense to strip the `sender_pc()` ? Don't all users expect it to be stripped?

The current code is being fairly cautious:

Native frames: saved PC might be signed. Therefore strip the pc.

Interpreter frames and compiled frames: the PC should never be signed. Assert this is the case.

For both Interpreter and Native frames we are getting the pc via sender_pc(), so can't push the strip inside sender_pc().

Alternatively, we could always strip instead of asserting. But that's not quite as nice.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4029


More information about the hotspot-dev mailing list