RFR: JDK-8267916: Make as_CompilerThread consistent with other as_*_thread methods

David Holmes dholmes at openjdk.java.net
Fri May 28 13:07:04 UTC 2021


On Fri, 28 May 2021 08:09:36 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple refactoring around `as_CompilerThread`. A new file, `compilerThread.inline.hpp`, is created to get around the circular dependency.

Sorry I'm not seeing the need for a new compilerThread.inline.hpp. That isn't making things consistent AFAICS - if we haven't factored out CompilerThread into its own header we shouldn't have compilerThread.inline.hpp.

David

-------------

PR: https://git.openjdk.java.net/jdk/pull/4240


More information about the hotspot-dev mailing list