RFR: 8267920: Create separate Events buffer for VMOperations [v2]

Stefan Karlsson stefank at openjdk.java.net
Fri May 28 18:17:59 UTC 2021


On Fri, 28 May 2021 17:11:18 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review coleenp
>
> src/hotspot/share/utilities/events.hpp line 471:
> 
>> 469: // These end up in the default log.
>> 470: typedef EventMarkWithLogFunction<Events::log> EventMark;
>> 471: typedef EventMarkWithLogFunction<Events::log_vm_operation> EventMarkVMOperation;
> 
> Can you add a comment just above EventMarkVMOperation line 470 like,
> // These go to the vm_operation log
> For some reason, I read the comment as applying to both instantiations.

Makes sense. Pushed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4243


More information about the hotspot-dev mailing list