RFR: JDK-8267916: Make as_CompilerThread consistent with other as_*_thread methods

Kim Barrett kbarrett at openjdk.java.net
Fri May 28 23:29:17 UTC 2021


On Fri, 28 May 2021 08:09:36 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple refactoring around `as_CompilerThread`. A new file, `compilerThread.inline.hpp`, is created to get around the circular dependency.

Changes requested by kbarrett (Reviewer).

src/hotspot/share/ci/ciEnv.hpp line 34:

> 32: #include "code/dependencies.hpp"
> 33: #include "code/exceptionHandlerTable.hpp"
> 34: #include "compiler/compilerThread.inline.hpp"

Including .inline.hpp by a .hpp is not allowed.

src/hotspot/share/compiler/compilerThread.inline.hpp line 29:

> 27: 
> 28: #include "runtime/thread.inline.hpp"
> 29: #include "compiler/compilerThread.hpp"

This include order is inconsistent with JDK-8267464.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4240


More information about the hotspot-dev mailing list