RFR: JDK-8276588: Change "ccc" to "CSR" in HotSpot sources

Alan Bateman alanb at openjdk.java.net
Thu Nov 4 07:29:19 UTC 2021


On Thu, 4 Nov 2021 02:10:37 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/oops/instanceKlass.cpp line 731:
>> 
>>> 729: }
>>> 730: 
>>> 731: // To remove these from requires an incompatible change and CSR review.
>> 
>> I don't know what this comment is trying to say; I think there might be missing words or something.  But the change for CCC -> CSR is fine.
>
> Given the 'R' in CSR already stands for Review this should have said "CSR request".
> 
> But I also have no idea what the comment is actually trying to say - what is "these" referring to???

I don't know why that comment is there. The API is Class::getSigners and any changes to its behavior would require a CSR, but we are free to change the implementation. So maybe the comment should be removed.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6240


More information about the hotspot-dev mailing list