RFR: 8275586: Zero: Simplify interpreter initialization

Andrew Dinn adinn at openjdk.java.net
Thu Nov 4 09:53:16 UTC 2021


On Wed, 20 Oct 2021 07:44:36 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> The prolog in `BytecodeInterpreter` is hairy due to early initialization of interpreter statics. Previous rewrites make it mostly redundant, and we can now simplify it.
> 
> This also implicitly fixes a initialization bug. If `JvmtiExport::can_post_interpreter_events()` changes at runtime, we will call into the uninitialized version:
> 
> 
>     // Call the interpreter
>     if (JvmtiExport::can_post_interpreter_events()) {
>       BytecodeInterpreter::run<true>(istate);
>     } else {
>       BytecodeInterpreter::run<false>(istate);
>     } 
> 
> 
> Additional testing:
>  - [x] Linux x86_64 fastdebug `make bootcycle-images`

Yes this looks good.

-------------

Marked as reviewed by adinn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6029


More information about the hotspot-dev mailing list