RFR: 8276095: ciReplay: replay failure due to incomplete ciMethodData information

Christian Hagedorn chagedorn at openjdk.java.net
Thu Nov 11 07:36:33 UTC 2021


On Thu, 11 Nov 2021 03:28:40 GMT, Dean Long <dlong at openjdk.org> wrote:

> The replay data was missing MethodData::_invocation_counter.  Adding it seems to fix the problem.  @rwestrel please verify if it works for you.  Also, with this change:
> 1. added a version number to the replay file
> 2. removed unnused ci fields
> 3. corrected comment in TestLambdas.java

Looks good to me! Thanks for also adapting the changes from 8275868 to use the new version number.

src/hotspot/share/ci/ciReplay.cpp line 900:

> 898: 
> 899:       // Only initialize the protection domain handle with the protection domain of the very first entry.
> 900:       // This also ensures that older replay files work.

Second sentence can now be removed with version numbers.

-------------

Marked as reviewed by chagedorn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6344


More information about the hotspot-dev mailing list