RFR: 8258192: Obsolete the CriticalJNINatives flag

Aleksey Shipilev shade at openjdk.java.net
Thu Nov 11 14:22:42 UTC 2021


On Thu, 11 Nov 2021 14:09:12 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp line 1746:
>> 
>>> 1744:   // NW     [ABI_REG_ARGS]             <-- 1) R1_SP
>>> 1745:   //        [outgoing arguments]       <-- 2) R1_SP + out_arg_slot_offset
>>> 1746:   //        [oopHandle area]           <-- 3) R1_SP + oop_handle_offset (save area for critical natives) ?
>> 
>> `?`. The comment `(save area for critical natives)` must be redundant now.
>
> I didn't know if the save area is still needed for something else, which is why I left the ?.  I can remove the comment but haven't made any  substantial changes here.  I'm not sure if they're needed or not, but I can't test them if I made them.

I mean, you did the same here: https://github.com/openjdk/jdk/pull/6343/files#diff-060e534de775616a893aa969f3639e53666cda9e93bed7c3a3c14b9cdc4cdba0L1553-L1554 -- and that change is understandable.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6343


More information about the hotspot-dev mailing list