RFR: 8258192: Obsolete the CriticalJNINatives flag [v2]

[Jorn Vernee]

On Thu, 11 Nov 2021 14:17:40 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp line 1905:
>> 
>>> 1903:   } else {
>>> 1904:     // Compute a valid move order, using tmp_vmreg to break any cycles
>>> 1905:     ComputeMoveOrder cmo(total_in_args, in_regs, total_c_args, out_regs, in_sig_bt, arg_order, tmp_vmreg);
>> 
>> `ComputeMoveOrder` is still used somewhere, or?
>
> Yes, it's used in
> cpu/x86/universalUpcallHandler_x86_64.cpp:  SharedRuntime::compute_move_order(in_sig_bt,

FWIW, I have a change in panama-foreign repo that replaces that use with a custom class. Will remove ComputeMoveOrder there as well, and it should be completely gone after the next JEP integration, probably in 19 (the JEP for 18 doesn't include that change).

-------------

PR: https://git.openjdk.java.net/jdk/pull/6343