RFR: 8276095: ciReplay: replay failure due to incomplete ciMethodData information [v2]
Christian Hagedorn
chagedorn at openjdk.java.net
Fri Nov 12 09:22:36 UTC 2021
On Fri, 12 Nov 2021 03:21:46 GMT, Dean Long <dlong at openjdk.org> wrote:
>> src/hotspot/share/ci/ciReplay.cpp line 645:
>>
>>> 643: _version = parse_int("version");
>>> 644: if (_version > REPLAY_VERSION) {
>>> 645: report_error("unrecognized version");
>>
>> Would be nice to print both versions numbers in error message.
>> Also I would like to be able ignore such error and process file anyway. Is `report_error` allows it?
>
>> Would be nice to print both versions numbers in error message.
>> Also I would like to be able ignore such error and process file anyway. Is report_error allows it?
>
> Currently report_error() saves the error string to be printed later, so to have an error message that requires formatting, I guess I would have to allocate the string using malloc or ResourceObj memory.
> Right now the only ignore flag is ReplayIgnoreInitErrors. I could introduce something like ReplayIgnoreAllErrors , or maybe turn this error into a warning.
> Christian is waiting on this version number support, so maybe I could create a separate RFE for the above suggestions?
It probably makes sense to turn this into a warning for now and file a follow up RFE as you have suggested.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6344
More information about the hotspot-dev
mailing list