RFR: 8276095: ciReplay: replay failure due to incomplete ciMethodData information [v2]

[Christian Hagedorn]

On Thu, 11 Nov 2021 16:59:39 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Dean Long has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - _current_mileage field is never used, stub out access
>>  - initialize _version to 0
>>  - remove comment
>
> src/hotspot/share/ci/ciReplay.cpp line 837:
> 
>> 835:     rec->_state = parse_int("state");
>> 836:     if (_version < 1) {
>> 837:       parse_int("current_mileage");
> 
> Why it is not assigned to `rec->_current_mileage` here?

I guess we could leave this in for old replay files with the initialization further down in `ciReplay::initialize()` if `_version < 1`. What do you think @dean-long ?

You should also update the method comment on L805: `<current_mileage>` -> `<invocation_counter>` (or change it to `<current_mileage>/<invocation_counter>` when leaving in the support for old replay files?).

-------------

PR: https://git.openjdk.java.net/jdk/pull/6344