RFR: 8276095: ciReplay: replay failure due to incomplete ciMethodData information [v2]

Dean Long dlong at openjdk.java.net
Fri Nov 12 20:25:37 UTC 2021


On Fri, 12 Nov 2021 03:36:59 GMT, Dean Long <dlong at openjdk.org> wrote:

>> The replay data was missing MethodData::_invocation_counter.  Adding it seems to fix the problem.  @rwestrel please verify if it works for you.  Also, with this change:
>> 1. added a version number to the replay file
>> 2. removed unnused ci fields
>> 3. corrected comment in TestLambdas.java
>
> Dean Long has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - _current_mileage field is never used, stub out access
>  - initialize _version to 0
>  - remove comment

> I guess we could leave this in for old replay files with the initialization further down in ciReplay::initialize() if _version < 1.

Yes, it's necessary to parse the value for old replay files, but the value is never used.  I'm not sure what you are suggesting about the initialization further down.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6344


More information about the hotspot-dev mailing list