RFR: 8277137: Set OnSpinWaitInst default value to "isb" for Arm Neoverse N1 [v2]

Evgeny Astigeevich duke at openjdk.java.net
Wed Nov 17 12:04:34 UTC 2021


On Wed, 17 Nov 2021 07:39:29 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

>> Evgeny Astigeevich has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Explicitly set OnSpinWaitInstCount to 1
>
> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 206:
> 
>> 204:     }
>> 205: 
>> 206:     if (FLAG_IS_DEFAULT(OnSpinWaitInst) && FLAG_IS_DEFAULT(OnSpinWaitInstCount)) {
> 
> Should these two be set independently? If I pass `-XX:OnSpinWaitInstCount=2` then `OnSpinWaitInst` will default to "none".

Hi Nick,
Thank you for reviewing the PR.

> Should these two be set independently?

I don't mind.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6415


More information about the hotspot-dev mailing list