RFR: 8277212: GC accidentally cleans valid megamorphic vtable inline caches [v2]
Coleen Phillimore
coleenp at openjdk.java.net
Thu Nov 18 17:34:43 UTC 2021
On Thu, 18 Nov 2021 14:32:50 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Review Coleen
>
> src/hotspot/share/code/compiledMethod.cpp line 482:
>
>> 480: }
>> 481: } else {
>> 482: return true;
>
> I've given up pretending to understand this code, but could you add a one line comment why you're returning true here? ie. if ic_metadata is NULL, it's a megamorphic call or already clean and shouldn't be cleaned.
Thanks for the comment.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6450
More information about the hotspot-dev
mailing list