RFR: 8275908: Record null_check traps for calls and array_check traps in the interpreter [v3]

Volker Simonis simonis at openjdk.java.net
Fri Nov 26 11:13:29 UTC 2021


On Fri, 26 Nov 2021 09:20:09 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Volker Simonis has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix Decompile.java test for non-JVMCI builds
>
> Thanks for doing the changes, they look good to me!
> 
>> @chhagedorn: I'm especially happy that you like the tests. As all too often the effort for a good test is much higher than for the fix itself :)
> 
> Yes, I couldn't agree more to that. It's sometimes underestimated how much time that is needed to come up with a good test. So, I always appreciate the extra effort :)

Thanks for the approval @chhagedorn .

I found that the new `Decompile.java` test failed on linux/x86_32. The reason for this is that 32-bit builds don't include JVMCI and without JMVCI the bimorphic inlining trap is called just `bimorphic` (in contrast to `bimorphic_or_optimized_type_check` for JVMCI builds`).

The fix is trivial and I hope your approval is also valid for the latest version :)

-------------

PR: https://git.openjdk.java.net/jdk/pull/6541


More information about the hotspot-dev mailing list