RFR: 8274521: jdk/jfr/event/gc/detailed/TestGCLockerEvent.java fails when other GC is selected

Kim Barrett kbarrett at openjdk.java.net
Fri Oct 1 09:33:32 UTC 2021


On Fri, 1 Oct 2021 09:20:35 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> test/jdk/jdk/jfr/event/gc/detailed/TestGCLockerEvent.java line 29:
>> 
>>> 27:  * @key jfr
>>> 28:  * @requires vm.hasJFR
>>> 29:  * @requires vm.gc == "G1" | vm.gc == null
>> 
>> I think this should instead be `@requires vm.gc.G1`.  The null check is wrong if running with a build that doesn't include G1 and the default GC is being used.
>
> True, it does look suspicious. I matched what other tests in the same folder are doing. Maybe we should fix them all at once in the followup PR?

I don't see a reason to change this test from being wrong to being differently wrong.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5756


More information about the hotspot-dev mailing list