RFR: JDK-8274795: AArch64: avoid spilling and restoring r18 in macro assembler

Wed Oct 6 08:48:11 UTC 2021

On Wed, 6 Oct 2021 06:10:50 GMT, Vladimir Kempik <vkempik at openjdk.org> wrote:

> Skip printing R18 in MacroAssembler::debug64() too as the R18 is missing in regs array after this patch

it's not, right? This PR changes `::pusha()`, but `generate_verify_oop()` uses `::push` and defines its own regset:

https://github.com/openjdk/jdk/blob/df125f680b6a4517109be80512a113064ca6281d/src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp#L599-L610

That said, I think `::debug64()` shouldn't touch `regs[30]` and `regs[31]`, but this is for another time.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5828