RFR: 8272586: emit abstract machine code in hs-err logs [v2]

[Doug Simon]

On Thu, 7 Oct 2021 01:43:05 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use nullptr instead of 0 or implicit NULL tests
>
> src/hotspot/share/utilities/vmError.cpp line 260:
> 
>> 258:     }
>> 259:     if (printed[i] == 0) {
>> 260:       printed[i] = owner;
> 
> Seems odd to have this side-effect in what appears to be a query - perhaps `add_to_printed` would be more apt: adds `owner` to the list of printed owners, unless already present. Returns `true` if owner was added, and false it if was already present, or else we've exceeded the printing limit. ?

That's a good suggestion. I've changed it to be `add_if_absent` and made it more generic.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5446