RFR: 8272723: Don't use Access API to access primitive fields [v3]
Roman Kennke
rkennke at openjdk.java.net
Thu Oct 7 16:59:11 UTC 2021
On Fri, 20 Aug 2021 08:51:54 GMT, Roman Kennke <rkennke at openjdk.org> wrote:
>> For earlier incarnations of Shenandoah, we needed to put barriers before accessing primitive fields. This is no longer necessary nor implemented/used by any GC, and we should simplify the code to do plain access instead.
>>
>> (We may want to remove remaining primitive access machinery in the Access API soon)
>>
>> Testing:
>> - [x] build x86_32 and x86_64
>> - [x] tier1
>> - [x] tier2
>> - [x] hotspot_gc
>
> Roman Kennke has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>
> - Merge branch 'master' into JDK-8272723
> - Remove redundant asserts
> - Revert to use RawAccess<MO_SEQ_CST> for volatile accesses
> - Fix alignment
> - Consolidate (obj)field_addr() variants
> - Remove remaining primitive Access API uses
> - 8272723: Don't use Access API to access primitive fields
This PR has been lingering for a while. Can I get another review, please? Maybe @fisk or @stefank?
Thanks, Roman
-------------
PR: https://git.openjdk.java.net/jdk/pull/5187
More information about the hotspot-dev
mailing list