RFR: 8272586: emit abstract machine code in hs-err logs [v5]
Martin Doerr
mdoerr at openjdk.java.net
Fri Oct 8 10:12:13 UTC 2021
On Thu, 7 Oct 2021 20:40:39 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> This enhances hs-err logs to:
>> * Show the [abstract machine code](https://bugs.openjdk.java.net/browse/JDK-8213084) of the crashing frame if a disassembler is not installed.
>> * Show machine code for the top frames on the native stack.
>>
>> An interpreter or stub frame is only shown if it is the crashing frame.
>>
>> A sample of the enhanced hs-err log can be seen [here](https://bugs.openjdk.java.net/secure/attachment/96664/hs_err_pid7179.log).
>
> Doug Simon has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR.
> Thanks, you're right. I placed it in `nmethod::decode2`: [5e00264](https://github.com/openjdk/jdk/commit/5e00264be9cf5871020a3023aa20c87fa72bdb43)
>
> BTW, I noticed that often nmethod info is written to `tty` during crash reporting. I tracked this down to [this change](https://github.com/dougxc/jdk/commit/4af237427144060d0b97c14a086401b0a3781198#diff-82948e0048fb88e1e9281b61394d9a9e2e0c8e75ab1a834c3bf943dbde73e2ffR618) where the `st` argument is ignored. @TheRealMDoerr do you think that should be fixed?
`nm->print_nmethod(verbose);` was already used before my change. I had only moved it out of `os::print_location`. But yes, would be good to fix it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5446
More information about the hotspot-dev
mailing list