RFR: 8274986: max code printed in hs-err logs should be configurable

Doug Simon dnsimon at openjdk.java.net
Mon Oct 11 08:37:27 UTC 2021


This PR adds a `ErrorLogPrintCodeLimit` (develop) option for configuring the amount of code printed in a hs-err log file. There's a hard limit of 10 so that the buffer used to avoid duplicates in `VMError::print_code` is stack allocated.
In addition, the Java stack is also scanned when considering code to print as the native stack may not have any Java compiled frames. For example, a transition into the VM through a RuntimeStub can prevent the native stack walk from seeing the frames above the stub.
The MachCodeFramesInErrorFile test has been made more robust in terms of validating its expectations of how C2 intrinsifies methods.

There's one other minor change to address [this comment](https://github.com/openjdk/jdk/pull/5446#issuecomment-938518814).

-------------

Commit messages:
 - make max code printed in hs-err log configurable and also scan Java stack for code to print
 - do not unnecessarily pollute tty

Changes: https://git.openjdk.java.net/jdk/pull/5875/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5875&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8274986
  Stats: 166 lines in 6 files changed: 71 ins; 37 del; 58 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5875.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5875/head:pull/5875

PR: https://git.openjdk.java.net/jdk/pull/5875


More information about the hotspot-dev mailing list