RFR: 8274986: max code printed in hs-err logs should be configurable

[David Holmes]

On Mon, 11 Oct 2021 08:18:47 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> src/hotspot/share/runtime/globals.hpp line 1339:
>> 
>>> 1337:           "number of stack frames to print in VM-level stack dump")         \
>>> 1338:                                                                             \
>>> 1339:   develop(int, ErrorLogPrintCodeLimit, 3,                                   \
>> 
>> Shouldn't this be at least diagnostic?  develop flags are fairly useless.
>
> I chose develop to be consistent with `StackPrintLimit`.
> What's the process for adding a diagnostic flag @dholmes-ora ? Should we change both `StackPrintLimit` and `ErrorLogPrintCodeLimit` to be diagnostic? I agree with Tom that having these as develop flags is of limited use.

I have no idea what the history of `StackPrintLimit` is but there doesn't seem to be any call to have it be a non-develop flag. I'm assuming 100 is plenty and noone ever needs to change it.

For the new flag, develop is pretty useless if the issue is that the default value may not show enough information. Making it diagnostic seems reasonable. If people hit an issue and the default value doesn't show enough information again then they can change the value and hopefully diagnose the problem further.

David

-------------

PR: https://git.openjdk.java.net/jdk/pull/5875