RFR: 8275031: runtime/ErrorHandling/MachCodeFramesInErrorFile.java fails when hsdis is present

David Holmes dholmes at openjdk.java.net
Mon Oct 11 12:14:10 UTC 2021


On Mon, 11 Oct 2021 09:52:03 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> tier1 test that is newly added by [JDK-8272586](https://bugs.openjdk.java.net/browse/JDK-8272586) fails on hsdis-enabled machine. I chose to fix it by annotating the real disassembly with `[Disassembly]`, and checking for its existence in the test.
> 
> Additional testing:
>  - [x] Test now passes when `hsdis` is installed
>  - [x] Test still passes when `hsdis` is not installed

This seems quite reasonable.

@dougxc please also review.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5888


More information about the hotspot-dev mailing list