RFR: 8274986: max code printed in hs-err logs should be configurable [v3]
Tom Rodriguez
never at openjdk.java.net
Mon Oct 11 19:52:59 UTC 2021
On Mon, 11 Oct 2021 19:45:23 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
>> This PR adds a `ErrorLogPrintCodeLimit` (develop) option for configuring the amount of code printed in a hs-err log file. There's a hard limit of 10 so that the buffer used to avoid duplicates in `VMError::print_code` is stack allocated.
>> In addition, the Java stack is also scanned when considering code to print as the native stack may not have any Java compiled frames. For example, a transition into the VM through a RuntimeStub can prevent the native stack walk from seeing the frames above the stub.
>> The MachCodeFramesInErrorFile test has been made more robust in terms of validating its expectations of how C2 intrinsifies methods.
>>
>> There's one other minor change to address [this comment](https://github.com/openjdk/jdk/pull/5446#issuecomment-938518814).
>
> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>
> print extra info for an nmethod in CodeBlob::dump_for_addr to st instead of tty in non-verbose mode
Marked as reviewed by never (Reviewer).
-------------
PR: https://git.openjdk.java.net/jdk/pull/5875
More information about the hotspot-dev
mailing list