Integrated: 8274986: max code printed in hs-err logs should be configurable

Doug Simon dnsimon at openjdk.java.net
Tue Oct 12 09:52:57 UTC 2021


On Fri, 8 Oct 2021 22:28:53 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

> This PR adds a `ErrorLogPrintCodeLimit` (develop) option for configuring the amount of code printed in a hs-err log file. There's a hard limit of 10 so that the buffer used to avoid duplicates in `VMError::print_code` is stack allocated.
> In addition, the Java stack is also scanned when considering code to print as the native stack may not have any Java compiled frames. For example, a transition into the VM through a RuntimeStub can prevent the native stack walk from seeing the frames above the stub.
> The MachCodeFramesInErrorFile test has been made more robust in terms of validating its expectations of how C2 intrinsifies methods.
> 
> There's one other minor change to address [this comment](https://github.com/openjdk/jdk/pull/5446#issuecomment-938518814).

This pull request has now been integrated.

Changeset: 33050f80
Author:    Doug Simon <dnsimon at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/33050f8013366f5e3a01ab1a75ba3fee9cc73089
Stats:     171 lines in 6 files changed: 76 ins; 38 del; 57 mod

8274986: max code printed in hs-err logs should be configurable

Reviewed-by: never, dholmes

-------------

PR: https://git.openjdk.java.net/jdk/pull/5875


More information about the hotspot-dev mailing list