RFR: 8274794: Print all owned locks in hs_err file

Coleen Phillimore coleenp at openjdk.java.net
Fri Oct 15 12:26:53 UTC 2021


On Thu, 14 Oct 2021 20:51:44 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> See CR for details.  This saves the created mutex in a mutex_array during Mutex construction so that all Mutex, not just the ones in mutexLocker.cpp can be printed in the hs_err file.  ThreadCritical is used to protect the mutex_array, and to avoid UB should be used when printing the owned locks, but since that is done during error handling, this seemed better not to lock during error handling.  There's 0 probability that another thread will be creating a lock during this error handling anyway.
> Tested with tier1-8.

Thanks for looking at this Thomas and for the experiments.  Mine weren't so large.  I'll change it to a doubly linked list. That does seem safer and better.
I made Mutex smaller by removing the embedded char[] so I think we can handle another pointer in the class.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5958


More information about the hotspot-dev mailing list