RFR: 8274794: Print all owned locks in hs_err file [v3]

Coleen Phillimore coleenp at openjdk.java.net
Mon Oct 18 15:58:51 UTC 2021


On Mon, 18 Oct 2021 15:48:07 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   tstuefe suggestions.
>
> src/hotspot/share/runtime/mutex.cpp line 290:
> 
>> 288:   ThreadCritical tc;
>> 289:   Mutex* old_next = _next_mutex;
>> 290:   assert(old_next != nullptr, "only static mutexes don't have a next");
> 
> How about "this list can never be empty"?

I am perfectly happy to use your bikeshed colors!

-------------

PR: https://git.openjdk.java.net/jdk/pull/5958


More information about the hotspot-dev mailing list