RFR: 8271124: CTW tests crashed with assert(is_valid_method(o)) failed: should be valid jmethodid [v2]

[Ioi Lam]

On Mon, 18 Oct 2021 19:44:15 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Add a lock in VirtualSpaceList::contains to protect the virtual space list for Metaspace::contains.  See CR for more details.
>> Tested with tier2 linux-aarch64-debug where the failure happened, and tier1-3 linux-x64-debug,linux-x64,windows-x64-debug in progress (almost done but it's being slow today).
>
> Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into jmethodid
>  - 8271124: CTW tests crashed with assert(is_valid_method(o)) failed: should be valid jmethodid

LGTM.

I looked at the other functions in this class, and it seems like VirtualSpaceList::is_full() has a similar problem. I filed https://bugs.openjdk.java.net/browse/JDK-8275440 to remove that function.

Other functions like  reserved_words(), committed_words() and num_nodes() also seem suspicious. @tstuefe can you take a look?

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5990