RFR: 8275712: Hashtable literal_size functions are broken

Zhengyu Gu zgu at openjdk.java.net
Thu Oct 21 13:36:05 UTC 2021


On Thu, 21 Oct 2021 11:26:36 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> The literal_size functions are used to estimate the size of held objects in some of our hashtables.
> 
> Two bugs:
> 1) They return int, but the returned value is in bytes and could be larger than MAX_INT.
> 2) Non-String objects report words instead of bytes.
> 
> Manually tested by running JFR and checking the output in JMC.

LGTM

-------------

Marked as reviewed by zgu (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6063


More information about the hotspot-dev mailing list