RFR: 8275717: Reimplement STATIC_ASSERT to use static_assert

Tue Oct 26 08:59:28 UTC 2021

On 2021-10-22 17:44, Kim Barrett wrote:
> The "unused typedef" warnings suggest a build with `-Wunused-local-typedefs` enabled.  I thought we were not enabling that (because it's not actually useful), but don't see such disabling and it's enabled by `-Wall`.  So why aren't we getting those warnings in any function where we use STATIC_ASSERT, for any gcc-based platform?
That's an interesting question.

I see we have a global disable for "unused" on both gcc and clang. (I'm 
not even sure why..?) I think that is a shorthand for several unused-* 
warnings. Maybe gcc and clang interprets this differently.

I agree that most of the "unused" warnings are not useful, but some are 
definitely helping to keep the code base clean from dead code.

/Magnus