RFR: 8275800: Redefinition leaks MethodData::_extra_data_lock [v2]

Coleen Phillimore coleenp at openjdk.java.net
Tue Oct 26 11:37:11 UTC 2021


On Mon, 25 Oct 2021 23:09:03 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add parameter to release_C_heap_structures.
>
> src/hotspot/share/oops/instanceKlass.cpp line 2693:
> 
>> 2691:   Klass::release_C_heap_structures();
>> 2692:   if (release_constant_pool) {
>> 2693:     constants()->release_C_heap_structures();
> 
> Just wanted to note that the order of de-allocations has been changed with this fix. It should not be important though. To be fully safe this deallocation can be moved to the end of `release_C_heap_structures`.

It shouldn't make a difference but to be perfectly conservative, I'll move it to the end of the function.  Thank you for the suggestion.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6105


More information about the hotspot-dev mailing list