RFR: 8275917: Some locks shouldn't allow_vm_block

Patricio Chilano Mateo pchilanomate at openjdk.java.net
Wed Oct 27 15:19:15 UTC 2021


On Tue, 26 Oct 2021 19:43:46 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> There were a few safepoint checking locks that passed allow_vm_block as true, that aren't taken by the VMThread.  I also made ClassInitError_lock behave like SystemDictionaryLock and the others in SystemDictionary::do_unloading so that doesn't require allow_vm_block either.  See the CR for more details.
> 
> Tested with tier1-6.

LGTM.

Thanks,
Patricio

src/hotspot/share/runtime/mutexLocker.cpp line 281:

> 279: 
> 280:   def(Heap_lock                    , PaddedMonitor, safepoint); // Doesn't safepoint check during termination.
> 281:   def(JfieldIdCreation_lock        , PaddedMutex  , safepoint);  // jfieldID, Used in VM_Operation

Is "Used in VM_Operation" still true?

-------------

Marked as reviewed by pchilanomate (Committer).

PR: https://git.openjdk.java.net/jdk/pull/6123


More information about the hotspot-dev mailing list