RFR: 8276054: JMH benchmarks for Fences [v3]

Claes Redestad redestad at openjdk.java.net
Thu Oct 28 21:44:18 UTC 2021


On Thu, 28 Oct 2021 21:17:40 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Consistent benchmark names: drop excess "Fence"
>>  - Add loadLoad tests too
>
> The Hotspot rules are documented here:
> 
> https://wiki.openjdk.java.net/display/HotSpot/Pushing+a+HotSpot+change
> 
> and in the process of migrating to the OpenJDK dev guide.
> 
> @shipilev Not sure why this was even posted to hotspot-dev for review ??? :)

@dholmes-ora we've not created a dedicated mailing list for microbenchmarks, rather stick to the convention that they are to be reviewed on the list(s) appropriate for the component being tested/stressed. Since these micros use `VarHandle` maybe they should have been reviewed on both core-libs and hotspot dev lists. Further then in this case I've interpreted the rules that even though the tests are VM-centric they don't touch the HotSpot source code and are thus not subject to the stricter set of rules put in place there.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6138


More information about the hotspot-dev mailing list