RFR: 8263375: Support stack watermarks in Zero VM [v2]
Erik Österlund
eosterlund at openjdk.java.net
Wed Sep 1 16:16:20 UTC 2021
On Wed, 1 Sep 2021 11:12:17 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Zero VM supports most of GCs. Since JDK 16, Shenandoah uses stack watermarks, so Zero has to support those if Shenandoah+Zero support is to remain. This PR adds the stack watermark support in Zero VM. This should also be useful as other projects, notably Loom, mature and depend on stack watermarks.
>>
>> Zero already calls into Hotspot safepoint machinery to do things, and it seems only the hooks for `on_iteration` and `on_unwind` are missing. AFAICS, Zero only has on-return safepoints, renamed it to be more precise.
>>
>> @fisk, do you see any obvious problems with this patch?
>>
>> Additional testing:
>> - [x] Linux x86_64 Zero `hotspot_gc_shenandoah` now passes
>
> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Notify only when unwinding messages are received
> - Merge branch 'master' into JDK-8263375-zero-stack-watermarks
> - Revert debugging
> - 8263375: Support stack watermarks in Zero VM
Looks good.
-------------
Marked as reviewed by eosterlund (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/4728
More information about the hotspot-dev
mailing list