RFR: 8273239: Standardize Ticks APIs return type

David Holmes dholmes at openjdk.java.net
Thu Sep 2 10:48:26 UTC 2021


On Wed, 1 Sep 2021 14:38:52 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

> Simple change on return types of Ticks API.
> 
> The call of `milliseconds()` in `spinYield.cpp` seems a bug to me, because the unit in the message is `usecs`. Therefore, I changed it to `microseconds()`.
> 
> Test: tier1

The JFR team introduced the extended form of these API's 6 years ago, and a more reduced version 8 years ago. Any changes to these API's should be approved by that team IMO. I'm more inclined to expect an API that produces integral values than fractions as the latter suggest you wanted greater resolution so you should have selected the function that provided that greater resolution. YMMV.

David

-------------

PR: https://git.openjdk.java.net/jdk/pull/5332


More information about the hotspot-dev mailing list