RFR: 8137018: [JVMCI] Encapsulate new Thread fields for JVMCI
Doug Simon
dnsimon at openjdk.java.net
Thu Sep 2 13:46:28 UTC 2021
On Thu, 2 Sep 2021 04:25:23 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> This evacuates all JVMCI related methods and fields into a separately declared struct.
>
> src/hotspot/share/jvmci/jvmci.hpp line 198:
>
>> 196:
>> 197: // Communicates the DeoptReason and DeoptAction of the uncommon trap
>> 198: int _pending_deoptimization;
>
> Nit: Why the extra large alignment spacing of all the declarations? (I'm not a fan of such alignment as it is too hard to maintain - and too hard to type in the first place!)
That probably comes from a time before we nicely commented each JVMCI field ;-)
I agree that there's no need for the alignment now.
-------------
PR: https://git.openjdk.java.net/jdk/pull/5339
More information about the hotspot-dev
mailing list