RFR: 8271569: Rename cdsoffsets.cpp to cdsConstants.cpp
David Holmes
dholmes at openjdk.java.net
Wed Sep 8 22:47:03 UTC 2021
On Wed, 8 Sep 2021 19:33:51 GMT, Yumin Qi <minqi at openjdk.org> wrote:
> Changed cdsOffsets.cpp to cdsConstants.cpp, now the offsets and constants are initialized static and searched separately.
> The offsets array could not use 'constexpr' since g++ on MacOs and VSC++ on Windows complained reinterpret_cast in 'offset_of' should not be used in constexpr initialization. Changed some field access for forming global list first.
>
> Tests: ter1-4
>
> Thanks
> Yumin
Hi Yumin,
> Changed cdsOffsets.cpp to cdsConstants.cpp
This is not showing up in the PR as a rename but as a new file. So there is no way to know what changes you may have made inside cdsConstants.cpp. The header file change shows as a rename.
David
-------------
PR: https://git.openjdk.java.net/jdk/pull/5423
More information about the hotspot-dev
mailing list