RFR: 8271569: Change cdsoffsets.cpp to cdsConstants.cpp

David Holmes david.holmes at oracle.com
Thu Sep 9 04:00:58 UTC 2021


On 9/09/2021 1:16 pm, Yumin Qi wrote:
> On Wed, 8 Sep 2021 22:44:14 GMT, David Holmes <dholmes at openjdk.org> wrote:
> 
>> Hi Yumin,
>>
>>> Changed cdsOffsets.cpp to cdsConstants.cpp
>>
>> This is not showing up in the PR as a rename but as a new file. So there is no way to know what changes you may have made inside cdsConstants.cpp. The header file change shows as a rename.
>>
>> David
> 
> Hi, David
>    git did not rename the 'old' to 'new' so the patch showed cdsConstants.cpp as a 'new' file. So I will change description as you indicated. Thanks

?? I'd rather you try again and do a rename :) Otherwise please advise 
what, if any, changes were actually made to the "new" file?

Thanks,
David

> Yumin
> 
> -------------
> 
> PR: https://git.openjdk.java.net/jdk/pull/5423
> 


More information about the hotspot-dev mailing list