RFR: 8273456: Do not hold ttyLock around stack walking

[David Holmes]

On Thu, 9 Sep 2021 14:54:01 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> This change moves the tty rank back down to near access, and prints stack traces to stringStream to avoid holding the tty lock while trying to take the stackwatermark lock.
> Tested with tier1-8 (7,8 still in progress but no failures so far).

Hi Coleen,

My only minor concern with these changes is that we lose information if there is a crash during any of these logging loops. Before you would (should?) see how far we got before a crash, but now there will not be any indication of that. But that is not the primary intention of this logging so I think the changes are okay.

Thanks,
David

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5445