RFR: 8273239: Standardize Ticks APIs return type [v2]

Albert Mingkun Yang ayang at openjdk.java.net
Fri Sep 10 10:09:04 UTC 2021


On Tue, 7 Sep 2021 17:27:00 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Simple change on return types of Ticks API.
>> 
>> The call of `milliseconds()` in `spinYield.cpp` seems a bug to me, because the unit in the message is `usecs`. Therefore, I changed it to `microseconds()`.
>> 
>> Test: tier1
>
> Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   template

Thank you for the patch; it's easier to discuss over a concrete implementation.

> NANOSECS_PER_SEC / (uint64_t)Rdtsc::frequency();

This integer division could cause precision loss when `T` is `double`, right?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5332


More information about the hotspot-dev mailing list